New Theme
#11
RE: New Theme
(10-25-2018, 08:14 AM)BackPlaner Wrote:  My only note is that the Avatar icons now seem to be stretched vertically next to each post.

I'm running into this, but I haven't been able to find a solution in the forums. Any tips?
josehill
O2

Trade Count: (0)
Posts: 18
Threads: 2
Joined: May 2018
Location: Northeast USA
Find Reply
06-05-2019, 03:15 PM
#12
RE: New Theme
I only see that on mobile. Not much I can do about it until an update to the framework looks.

I'm the system admin of this site. Private security technician, licensed locksmith, hack of a c developer and vintage computer enthusiast. 

https://contrib.irixnet.org/raion/ -- contributions and pieces that I'm working on currently. 

https://codeberg.org/SolusRaion -- Code repos I control

Technical problems should be sent my way.
Raion
Chief IRIX Officer

Trade Count: (9)
Posts: 4,240
Threads: 533
Joined: Nov 2017
Location: Eastern Virginia
Website Find Reply
06-05-2019, 03:38 PM
#13
RE: New Theme
Whether or not one sees the distorted avatars will vary depending on the size of one's browser window and the size of the avatar.  In this thread and in my preferred browser Raion's avatar is fine but josehill's isn't.

Looking at the HTML for the site reveals the issue:  josehill's avatar has a native size of 250x250 pixels while Raion's is 128x128.  My browser window only allows about 137 pixels of width.  So Raion's fits in that width while josehill's does not.  But josehill's avatar still uses the full 250 pixels of its height, thus looking elongated.  (Actually, it is at its proper height but narrower than it should be.)  

If I expand the browser window wider, then both avatars are fine, since there's more width for the sidebar that's holding the avatars and josehill's no longer needs to be squished horizontally.

The simple fix is to remove the "width=" and "height=" attributes from the <img> tag that holds the avatar images.  There is CSS elsewhere that specifies the max-width of the image to be the size of its container (preventing overly large avatars from being a problem) but nothing about height, which means the browser would maintain the avatar's original aspect ratio when scaling based solely on the CSS.  The added height tag overrides that, causing the distortion some people are seeing.

But that's a fix for the forum software's developers to implement.  As Raion said, there's not much he can do about that.  Maybe file a bug report with the upstream developers, but that's probably already been done by somebody else using the same forum software.

Smaller (narrower) avatars and wider browser windows will reduce the likelihood of seeing the problem.  But those are workarounds for users who are bothered by it, not anything for the forum admins or devs to do.

SGI:  Indigo, Indigo2, Octane, Origin 300
Sun:  SPARCstation 20 (x4), Ultra 2, Blade 2500, T5240
HP:  9000/380, 425e, C8000
Digital: DECstation 5000/125, PWS 600au
jpstewart
Developer

Trade Count: (1)
Posts: 444
Threads: 6
Joined: May 2018
Location: SW Ontario, CA
Find Reply
06-05-2019, 05:20 PM
#14
RE: New Theme
Yeah I'd do it myself but the CSS for MyBB is stored in a special xml file and thus it's a pain to override, I ended up having to use inline css to fix a few things, which we don't need to proliferate.

I'm the system admin of this site. Private security technician, licensed locksmith, hack of a c developer and vintage computer enthusiast. 

https://contrib.irixnet.org/raion/ -- contributions and pieces that I'm working on currently. 

https://codeberg.org/SolusRaion -- Code repos I control

Technical problems should be sent my way.
Raion
Chief IRIX Officer

Trade Count: (9)
Posts: 4,240
Threads: 533
Joined: Nov 2017
Location: Eastern Virginia
Website Find Reply
06-05-2019, 05:24 PM
#15
RE: New Theme
(06-05-2019, 05:20 PM)jpstewart Wrote:  Smaller (narrower) avatars and wider browser windows will reduce the likelihood of seeing the problem.  But those are workarounds for users who are bothered by it, not anything for the forum admins or devs to do.

Thanks for the sleuthing, JP. I'll just switch to a smaller avatar for now. No need for any of the admins to divert their attention from more critical tasks.
josehill
O2

Trade Count: (0)
Posts: 18
Threads: 2
Joined: May 2018
Location: Northeast USA
Find Reply
06-05-2019, 06:31 PM
#16
RE: New Theme
I know mine was wonky but looks fine now, and yours looks fine too josehill. Gotta love it when a plan comes together, because (to quote The Way of the Gun), usually a plan is just "a list of things that don't happen." ... Tongue

Project: Temporarily lost at sea
Plan: World domination! Or something...
vishnu
Tezro, Octane2, 2 x Onyx4

Trade Count: (0)
Posts: 1,245
Threads: 41
Joined: Dec 2017
Location: Minneapolis, Minnesota USA
Find Reply
06-07-2019, 04:54 AM


Forum Jump:


Users browsing this thread: 1 Guest(s)